issue_comments: 656899749

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4215#issuecomment-656899749 https://api.github.com/repos/pydata/xarray/issues/4215 656899749 MDEyOklzc3VlQ29tbWVudDY1Njg5OTc0OQ== 1217238 2020-07-10T21:29:22Z 2020-07-10T21:29:22Z MEMBER

Sounds good to me! coordinates were the main example that came up when I wrote this (and we needed them for xarray's data model), but these other attributes look like they serve a similar role.

Question: Should we allow decode_coords to control whether variables mentioned in these attributes are set as coordinate variables?

I don't think this is necessary. It's easy to explicitly set or reset coordinates afterwards if desired.

My one concern with #2844 is clarifying the role of encoding vs. attrs.

I think we should probably ensure that xarray always propagates encoding exactly like how it propagates attrs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   654889988