issue_comments: 656358719
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/4208#issuecomment-656358719 | https://api.github.com/repos/pydata/xarray/issues/4208 | 656358719 | MDEyOklzc3VlQ29tbWVudDY1NjM1ODcxOQ== | 3460034 | 2020-07-09T21:24:42Z | 2020-07-09T21:26:37Z | CONTRIBUTOR | @rpmanser That sounds like a good plan to me at least, but it would be great if any of the xarray maintainers would be able to chime in. Also, thanks again for being willing to work on this while I try working on https://github.com/dask/dask/issues/4583. The hidden 4th step is of course testing--primarily that this doesn't break existing functionality, but also that it works for duck Dask Arrays other than Dask Arrays themselves (not sure if Pint Quantities in upcoming v0.15 or a mocked class would be better). Also, thank you @dcherian for pointing out those checks, you found them faster than I did! |
{
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
653430454 |