issue_comments: 656349279

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4208#issuecomment-656349279 https://api.github.com/repos/pydata/xarray/issues/4208 656349279 MDEyOklzc3VlQ29tbWVudDY1NjM0OTI3OQ== 19578931 2020-07-09T21:01:07Z 2020-07-09T21:01:07Z CONTRIBUTOR

I can go ahead with putting together a PR for this. Before I do so, I'd like to clarify what is expected.

  • Implement the is_duck_dask_array() function
  • In that implementation, use dask.base.is_dask_collection() and the existing duck array check(s)
  • Replace isinstance(x, dask.array.Array) checks with the new is_dask_duck_array() function

I searched for existing duck array checks in xarray and nothing immediately obvious to me is showing up. It looks like a check for __array_function__ is inappropriate based on discussion in #3917. Could someone point out the proper duck array check?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   653430454