home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 651984472

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4186#issuecomment-651984472 https://api.github.com/repos/pydata/xarray/issues/4186 651984472 MDEyOklzc3VlQ29tbWVudDY1MTk4NDQ3Mg== 15720911 2020-06-30T19:02:28Z 2020-06-30T19:02:28Z NONE

Sorry @shoyer, I didn't notice you have pushed new commits to #4184 and thought you meant to just remove the DataFrame.set_index. Your latest commits indeed give the correct result. My concern was when another person works on this and didn't get the context that idx might be different from dataframe.index and new bugs could potentially be introduced. Though consider the limited scope where we are maintaining both idx and dataframe, I guess it should be fine.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  646716560
Powered by Datasette · Queries took 0.627ms · About: xarray-datasette