issue_comments: 651700823

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-651700823 https://api.github.com/repos/pydata/xarray/issues/4060 651700823 MDEyOklzc3VlQ29tbWVudDY1MTcwMDgyMw== 5821660 2020-06-30T10:14:53Z 2020-06-30T10:14:53Z MEMBER

@mathause I've tested your suggestion but I do not know, what better error message you expect from the dask side.

  • xr.apply_ufunc(..., output_core_dims=[["z"]], output_sizes={"z": 1}) signature.to_gufunc_string() will output ()->(dim0) (and output_sizes will be {'dim0': 1}
  • xr.apply_ufunc(..., output_core_dims=[["z"]], output_sizes={"y": 1}) signature.to_gufunc_string() will output ()->(dim0) (and output_sizes will be {'y': 1}

So the second will fail with KeyError: 'dim0'.

I think we can't get proper error messages from dask side, because dask doesn't know anything about the new dimension name ( at least not from signature.to_gufunc_string()). Should we catch the error and add a meaningful output?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   618081836