home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 651062460

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4102#issuecomment-651062460 https://api.github.com/repos/pydata/xarray/issues/4102 651062460 MDEyOklzc3VlQ29tbWVudDY1MTA2MjQ2MA== 14808389 2020-06-29T11:45:39Z 2020-06-29T13:23:24Z MEMBER

I would suggest just creating the full directory tree, e.g., with os.makedirs(path, exist_ok=True). I don't think we want to let this be inconsistent.

When writing this I wanted to make sure we didn't force a ~/.cache folder on everyone, regardless of the platform.

After looking into this a bit more, it seems we would probably need to have different cache folders for different platforms: - on windows, the path is given by APPDATA (or LOCALAPPDATA, not sure) (I can't find a official resource for this) - on macos it can be either ~/Library/Caches (or ~/Library/Application Support?) - on unix (following the freedesktop basedir spec) it is indicated by XDG_CACHE_HOME with a default of ~/.cache.

So a currently released version of xarray will always put it into ~/.xarray_tutorial_data, and my changes will partially align with the freedesktop spec.

How closely should we follow those specifications?

Edit: appdirs solves that (but: it's a new dependency)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  626083981
Powered by Datasette · Queries took 2.29ms · About: xarray-datasette