home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 642554509

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4144#issuecomment-642554509 https://api.github.com/repos/pydata/xarray/issues/4144 642554509 MDEyOklzc3VlQ29tbWVudDY0MjU1NDUwOQ== 10194086 2020-06-11T10:20:33Z 2020-06-11T10:20:33Z MEMBER

The mypy check throws an error: xarray/core/dataset.py:1250: error: Overloaded function signature 2 will never be matched: signature 1's parameter type(s) are the same I think you can ignore the other failures. Should that be:

```python @overload def getitem(self, key: Hashable) -> DataArray: ...

@overload
def __getitem__(self, key: Iterable[Hashable]) -> "Dataset":
    ...

`` ? Only guessing, though - it wasAny` so there may be more options. @crusaderky

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  636611699
Powered by Datasette · Queries took 240.797ms · About: xarray-datasette