home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 641607365

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4131#issuecomment-641607365 https://api.github.com/repos/pydata/xarray/issues/4131 641607365 MDEyOklzc3VlQ29tbWVudDY0MTYwNzM2NQ== 29104956 2020-06-09T22:07:42Z 2020-06-09T22:07:42Z NONE

Ah, gotchya. Yeah it was quite jarring to see that leaving the open_dataset context manager didn't produce any noticeable change in the data accessibility.

In my passing opinion, it seems like it would be best to protect people, especially those who don't understand what context managers do, from themselves and have a closed dataset raise upon being queried. This is how all "closed" objects behave in my experience.

I'll leave this issue open in case there is any useful discussion to host here. But feel free to close it if that is more appropriate.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  634869703
Powered by Datasette · Queries took 0.749ms · About: xarray-datasette