issue_comments: 635194699

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-635194699 https://api.github.com/repos/pydata/xarray/issues/4060 635194699 MDEyOklzc3VlQ29tbWVudDYzNTE5NDY5OQ== 5821660 2020-05-28T08:22:13Z 2020-05-28T08:22:13Z MEMBER

Thanks @shoyer and @mathause. I've tried to adapt the PR to your comments.

  • The meta and output_sizes parameters should be and the vectorize and output_dtypes parameters can be given within the dask_gufunc_kwargs (which have priority). This would also be the place for allow_rechunk. Everything is mentioned in the docstring and warnings are issued to use the new dask_gufunc_kwargs. The dask_gufunc_kwargs itself is used to hold all keyword arguments for dask.array.apply_gufunc.

  • vectorization is done inside apply_ufunc only for dask not parallelized. In that case it is deferred to dask.array.apply_gufunc.

  • for chunking problems (core dimension with multiple chunks and non-core dimensions with different chunksizes) we let dask raise the errors.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   618081836