home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 634876945

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3847#issuecomment-634876945 https://api.github.com/repos/pydata/xarray/issues/3847 634876945 MDEyOklzc3VlQ29tbWVudDYzNDg3Njk0NQ== 14808389 2020-05-27T19:04:40Z 2020-05-27T19:04:40Z MEMBER

then it seems that this PR removes this intentional restriction. I'm not sure it is still needed, though: we don't use np.testing.assert_allclose internally because we want to provide our own error messages, and the actual comparison is done with https://github.com/pydata/xarray/blob/e5cc19cd8f8a69e0743f230f5bf51b7778a0ff96/xarray/core/duck_array_ops.py#L204 which should allow dispatching

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  577425749
Powered by Datasette · Queries took 0.604ms · About: xarray-datasette