issue_comments: 634774468

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-634774468 https://api.github.com/repos/pydata/xarray/issues/4060 634774468 MDEyOklzc3VlQ29tbWVudDYzNDc3NDQ2OA== 1217238 2020-05-27T16:14:33Z 2020-05-27T16:14:33Z MEMBER

Looking at the internals of dask.array.apply_gufunc, it looks like it passes on **kwargs to blockwise. blockwise gets called twice, first with only **kwargs and then with both meta and **kwargs: https://github.com/dask/dask/blob/77628f2d5248cc61cc366cac3e400b6df5c654c1/dask/array/gufunc.py#L422 https://github.com/dask/dask/blob/77628f2d5248cc61cc366cac3e400b6df5c654c1/dask/array/gufunc.py#L439

So it seems we can actually still pass on a meta argument explicitly, at least in the first case.

Here's my suggestion for moving forwarding:

  • If meta was explicitly set (meta is not None), pass it into apply_gufunc in **kwargs
  • Otherwise, omit meta.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   618081836