home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 634611339

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3847#issuecomment-634611339 https://api.github.com/repos/pydata/xarray/issues/3847 634611339 MDEyOklzc3VlQ29tbWVudDYzNDYxMTMzOQ== 14808389 2020-05-27T11:57:18Z 2020-05-27T11:57:18Z MEMBER

I needed to use assert_allclose in the pint tests in #3975, so I modified it to use .data instead of .values and now the exact same tests are failing. So it seems that assert_allclose never worked with dask but always converted to numpy. Would it make sense to investigate further, or is it better to just wait until we can merge this?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  577425749
Powered by Datasette · Queries took 0.602ms · About: xarray-datasette