home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 634583266

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-634583266 https://api.github.com/repos/pydata/xarray/issues/4060 634583266 MDEyOklzc3VlQ29tbWVudDYzNDU4MzI2Ng== 5821660 2020-05-27T10:53:25Z 2020-05-27T10:53:25Z MEMBER

What I was trying to say - this is a change that can break existing code and it is not easy to do a proper deprecation cycle (i.e. only throw a warning). (I think allow_rechunk=True is not a good default.)

Yes, sure, I didn't think about the effects on existing code. We might need to capture both ValueErrors and handle differently. I'll try to come up with a proposal for this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  618081836
Powered by Datasette · Queries took 77.709ms · About: xarray-datasette