home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 634572185

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-634572185 https://api.github.com/repos/pydata/xarray/issues/4060 634572185 MDEyOklzc3VlQ29tbWVudDYzNDU3MjE4NQ== 10194086 2020-05-27T10:28:26Z 2020-05-27T10:28:26Z MEMBER

output_dtypes: yes I think the docs should be updated

What I was trying to say - this is a change that can break existing code and it is not easy to do a proper deprecation cycle (i.e. only throw a warning). (I think allow_rechunk=True is not a good default.)


Ok an easier idea (could be brittle, though):

```python try: res = da.apply_gufunc(...)

catch error that was not raised in earlier versions of xr.apply_ufunc

except ValueError as e: if "with different chunksize present" in str(e): warnings.warn(str(e) + " This will throw an error in the future.") res = da.apply_gufunc(..., allow_rechunk=True) else: raise

``` However, I am only throwing around ideas - this is certainly not up to me. Let's see what the others think. Maybe they have an opinion or a better idea.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  618081836
Powered by Datasette · Queries took 0.879ms · About: xarray-datasette