issue_comments: 633393615

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4089#issuecomment-633393615 https://api.github.com/repos/pydata/xarray/issues/4089 633393615 MDEyOklzc3VlQ29tbWVudDYzMzM5MzYxNQ== 5635139 2020-05-25T06:03:24Z 2020-05-25T06:03:24Z MEMBER

This looks great! I think it's fine to have a simple implementation like this, even if it's not perfectly efficient. Well done for getting something working @AndrewWilliams3142 .

For the future: let's move away from using np.random in docstrings, since they're not reproducible, and will never pass a doctest.

Anything remaining before merging?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   623751213