home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 631702113

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-631702113 https://api.github.com/repos/pydata/xarray/issues/4060 631702113 MDEyOklzc3VlQ29tbWVudDYzMTcwMjExMw== 1217238 2020-05-20T20:16:09Z 2020-05-20T20:16:09Z MEMBER

Maybe this is too defensive/surprising, and could be relaxed.

You would remove the daks="forbidden" branch and not the dask="parallelized"?

For the functions that don't handle dask arrays gracefully, dask="parallelized" would be the better option?

This is probably another good motivation: defaulting to dask='forbidden' forces users to make an explicit choice about whether or not use dask='parallelized'.

The problem is that we don't have any way to detect ahead of time whether the applied function already supports dask arrays (e.g., if it is built-up out of functions from dask.array). If it does, we don't want to set dask='parallelized' but rather let the function handle dask arrays itself.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  618081836
Powered by Datasette · Queries took 0.567ms · About: xarray-datasette