issue_comments: 630840345

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4060#issuecomment-630840345 https://api.github.com/repos/pydata/xarray/issues/4060 630840345 MDEyOklzc3VlQ29tbWVudDYzMDg0MDM0NQ== 5821660 2020-05-19T14:03:42Z 2020-05-20T13:41:41Z MEMBER

I've given this a try, but this will need some design decisions.

  • currently vectorize is handled in any case if requested, before falling through the if/else. dask.array.apply_gufunc takes vectorize as parameter, so for dask we do not need to apply vectorization. We would need to apply vectorize only for non-dask cases (maybe just before calling the final function).
  • currently dask is only handled, if dask keyword is issued ('allowed' and parallelized). From my perspective the dask keyword is not needed any more. We could just divert to the apply_gufunc when dask backed arrays are detected.

This will really have much impact on the code/tests. I'll come up with a updated PullRequest in short time, but any thoughts /remarks whatsoever are very much appreciated. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   618081836