issue_comments: 630713011

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4077#issuecomment-630713011 https://api.github.com/repos/pydata/xarray/issues/4077 630713011 MDEyOklzc3VlQ29tbWVudDYzMDcxMzAxMQ== 10194086 2020-05-19T09:47:33Z 2020-05-19T09:47:33Z MEMBER

Raising an error when the start time is equal is certainly a good idea. What I am less sure about is what to do when the end is equal to the start - maybe a warning?

The second case would be the following: python print(ds0) print(ds1) ``` <xarray.Dataset> Dimensions: (x: 2) Coordinates: * x (x) int64 0 1 Data variables: foo ...

<xarray.Dataset> Dimensions: (x: 2) Coordinates: * x (x) int64 1 2 Data variables: foo ... and `auto_combine` would lead to:python xr.combine_by_coords([ds0, ds1]) <xarray.Dataset> Dimensions: (x: 2) Coordinates: * x (x) int64 0 1 1 2 Data variables: foo ... ```

For the first case you can probably check if all elements of order are unique:

https://github.com/pydata/xarray/blob/2542a63f6ebed1a464af7fc74b9f3bf302925803/xarray/core/combine.py#L99

ps: Overlapping indices are not a problem - it is checked that the result is monotonic:

https://github.com/pydata/xarray/blob/2542a63f6ebed1a464af7fc74b9f3bf302925803/xarray/core/combine.py#L748

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   620514214