issue_comments: 630510525

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4076#issuecomment-630510525 https://api.github.com/repos/pydata/xarray/issues/4076 630510525 MDEyOklzc3VlQ29tbWVudDYzMDUxMDUyNQ== 1217238 2020-05-19T00:50:18Z 2020-05-19T00:50:18Z MEMBER

I think it would be preferable to close the ZipStore in this case. But I might be missing something?

If we make users explicitly open their own Zarr stores, then I think it's best to let them close them, themselves. If we closed them automatically, then they couldn't add their own files into the store outside of xarray.

It would make sense to automatically close stores if they were opened inside to_zarr(), e.g., if we had some logic that automatically opened a zip store when the file path ends in ".zip". This would not be a bad idea (small files are quite wasteful on most filesystems), but is not currently the case, as I understand it.

At the very least, we could add a note to the documentation about this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   620468256