issue_comments: 628280174

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3960#issuecomment-628280174 https://api.github.com/repos/pydata/xarray/issues/3960 628280174 MDEyOklzc3VlQ29tbWVudDYyODI4MDE3NA== 14808389 2020-05-13T22:32:26Z 2020-05-13T23:01:19Z MEMBER

revisiting this: does it make sense to require calling if a __call__ is defined? I.e. always require da.accessor().attribute instead of da.accessor.attribute?

This would probably need changes to the register_*_accessor decorators that adds the checking, but that way we could also make sure people don't use this to add new functions: if __call__ may only return self or a new object of the same type, abusing the accessor decorators would be a lot harder. The frequent creation of new objects would require a cheap Accessor.__init__, though.

Another way to achieve that would be to patch out __call__ and put it on a wrapper class, as mentioned above.

Does that make sense or is this too complicated?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   597566530