issue_comments: 626181186

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3922#issuecomment-626181186 https://api.github.com/repos/pydata/xarray/issues/3922 626181186 MDEyOklzc3VlQ29tbWVudDYyNjE4MTE4Ng== 2448579 2020-05-09T14:04:23Z 2020-05-09T14:04:56Z MEMBER

The test fails for object arrays because we compute eagerly in nanops._nan_argminmax_object to raise an error for all-NaN slices.

To solve this we could 1. fix #3884 so that nanargmin, nanargmax never raise an error for all-NaN slices. 2. Figure out some clever way to raise the error at compute time rather than graph construction time.

For now, I bumped up max_computes to 1 for object arrays. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   591101988