issue_comments: 625865523

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4035#issuecomment-625865523 https://api.github.com/repos/pydata/xarray/issues/4035 625865523 MDEyOklzc3VlQ29tbWVudDYyNTg2NTUyMw== 1197350 2020-05-08T15:16:54Z 2020-05-08T15:16:54Z MEMBER

Stephan, this seems like a great addition. Thanks for getting it started!

I'm curious how this interacts with dimension coordinates. Your example bypasses this. But what if dimension coordinates are present. How do we handle alignment issues? For example, what if I call ds.to_zarr(path , region=selection), but the dimension coordinates of ds don't align with the dimension coordinates of the store at path"

  1. Officially document that the compute argument only controls writing array values, not metadata (at least for zarr).

:+1:

4. Like (2), but raise an error instead of a warning. Require the user to explicitly drop them with .drop(). This is probably the safest behavior.

:+1:

I think only advanced users will want to use this feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   613012939