issue_comments: 619398262

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4002#issuecomment-619398262 https://api.github.com/repos/pydata/xarray/issues/4002 619398262 MDEyOklzc3VlQ29tbWVudDYxOTM5ODI2Mg== 1217238 2020-04-25T15:42:29Z 2020-04-25T15:42:29Z MEMBER

We do not use assert for user facing validation

On Sat, Apr 25, 2020 at 3:37 AM Prajjwal Nijhara notifications@github.com wrote:

@shoyer https://github.com/shoyer, I partially agree with your statement that " assert is the appropriate way to verify internal invariants". This is correct but not every time. When you see the link that you shared it also shows that most of the assert statements are used in tests and not in simple files.

Let me quote again "Since assert provides an easy way to check some condition and fail execution, it’s very common for developers to use it to check validity. But when the Python interpreter is invoked with the -O (optimize) flag, the assert statements are removed from the bytecode. So, if assert statements are used for user-facing validation in production code, the block won’t be executed at all — potentially opening up a security vulnerability. It is recommended to use assert statements only in tests."

Again it's just a suggestion IMHO

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/4002#issuecomment-619358326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVWLOJULCHNMC5F4KZTROK4NZANCNFSM4MQL3K7A . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   606549469