issue_comments: 616828508

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3960#issuecomment-616828508 https://api.github.com/repos/pydata/xarray/issues/3960 616828508 MDEyOklzc3VlQ29tbWVudDYxNjgyODUwOA== 14808389 2020-04-20T21:47:45Z 2020-04-20T21:47:45Z MEMBER

I tried to polish the example (see here) and also added a note trying to explicitly discourage using this to add new methods to the main namespace.

This makes it clear, though, that the error message for the required parameter implementation could be better. For replacement, I think we could use either a new keyword-only parameter to the register_*_functions, a class decorator or some sort of mixin / base class / metaclass. The decorators would generate some sort of wrapper that enforces the __call__ while the other options would need to do some kind of magic. Considering that, I think I'd prefer using a decorator (but I'm not sure how important this use-case is).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   597566530