issue_comments: 611950517
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/3959#issuecomment-611950517 | https://api.github.com/repos/pydata/xarray/issues/3959 | 611950517 | MDEyOklzc3VlQ29tbWVudDYxMTk1MDUxNw== | 6130352 | 2020-04-10T09:08:06Z | 2020-04-10T09:08:06Z | NONE | Thanks @TomNicholas, some thoughts on your points:
I'm ok with the subtype being lost after running some methods. I saw that so I'm assuming all functions that do anything with the data structures take and return Xarray objects alone.
Accessors could work but the issues I see with them are:
```python ds.haplo.do_custom_analysis_1() Do something with coords/indexes that causes a new Dataset to be createde.g. ds.reset_index ultimately hits https://github.com/pydata/xarray/blob/1eedc5c146d9e6ebd46ab2cc8b271e51b3a25959/xarray/core/dataset.py#L882which creates a new Datasetds = ds.reset_index() The
|
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
597475005 |