home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 610288219

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3936#issuecomment-610288219 https://api.github.com/repos/pydata/xarray/issues/3936 610288219 MDEyOklzc3VlQ29tbWVudDYxMDI4ODIxOQ== 3958036 2020-04-07T09:45:24Z 2020-04-07T09:45:24Z CONTRIBUTOR

These test failures seem to have uncovered a larger issue: overriding a method injected by ops.inject_all_ops_and_reduce_methods(DataArray, priority=60) is tricky. I think there may be a way around it by mangling the name of the injected operation if that method is already defined on the class; I tried this and it nearly works, but I think I need to implement an override for argmin/argmax on Variable, because DataArray.__array_wrap__ uses the Variable version of the method... Work in progress!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  594594646
Powered by Datasette · Queries took 0.763ms · About: xarray-datasette