issue_comments: 609591692

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3936#issuecomment-609591692 https://api.github.com/repos/pydata/xarray/issues/3936 609591692 MDEyOklzc3VlQ29tbWVudDYwOTU5MTY5Mg== 5821660 2020-04-06T06:31:12Z 2020-04-06T06:31:22Z MEMBER

+1 for making argmin/argmax (and idxmin/idxmax) work, when given multiple dimensions.

According to the current docstring it should already work that way for argmin/'argmax`:

Reduce this DataArray’s data by applying argmin along some dimension(s).

Returns: New DataArray/Dataset object with argmin applied to it's data and the indicated dimension(s) removed

But this behaviour is broken currently (works only for one given dim).

My main concern for changing the API as suggested above is, how should we discern (at least for argmin/argmax), if the user want's to:

  1. reduce over all given dimensions? (current behaviour according to docstring)
  2. reduce along all given dimensions? (suggested behaviour by @johnomotani [please correct if I'm wrong])
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   594594646