home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 609488771

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3936#issuecomment-609488771 https://api.github.com/repos/pydata/xarray/issues/3936 609488771 MDEyOklzc3VlQ29tbWVudDYwOTQ4ODc3MQ== 35968931 2020-04-05T21:39:19Z 2020-04-05T21:39:19Z MEMBER

Another option would be to overload argmin

+1 for overloading argmin (and later idxmin). IMO we should never have one function for a 1D operation and one for an N-D operation if we can avoid it, everything should be N-dimensional.

I also really like how neat this resultant property is python da.isel(da.argmin(list_of_dim)) == da.min(list_of_dim) we could even use a hypothesis test to check it...

I think returning a dict of indices would be much more useful, but it does change existing behaviour (more useful because you can then do da.isel(da.argmin())).

Although it's breaking and would require a deprecation cycle, I think this is what we should aim for.

there's a not-very-helpful exception

Yes let's take the time to make that clearer for users - this will be a commonly-used function.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  594594646
Powered by Datasette · Queries took 0.876ms · About: xarray-datasette