issue_comments: 609468040
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3936#issuecomment-609468040 | https://api.github.com/repos/pydata/xarray/issues/3936 | 609468040 | MDEyOklzc3VlQ29tbWVudDYwOTQ2ODA0MA== | 1217238 | 2020-04-05T19:19:41Z | 2020-04-05T19:19:41Z | MEMBER | This looks really comprehensive, thank you! Before doing a really careful review here, I'd like to try to work out the full API design we want. I'll write out some of my thoughts here, but your thoughts would also be very welcome! Here's my summary of the current situation:
1. We have two pairs of methods, This PR implements the multidimensional equivalent of My first concern is about the name: it isn't obvious to me whether Another option would be to overload I think I like this last option best but I would be curious what others think! @pydata/xarray any thoughts on this? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
594594646 |