issue_comments: 608110925

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3643#issuecomment-608110925 https://api.github.com/repos/pydata/xarray/issues/3643 608110925 MDEyOklzc3VlQ29tbWVudDYwODExMDkyNQ== 14808389 2020-04-02T21:54:06Z 2020-04-02T21:56:33Z MEMBER

it seems we can't use __array_function__ to check if the type should be handled or not (using __array_function__ works, but that's by accident, I think, and stops working once/if we implement __array_function__on xarray objects).

~I'd say it is pretty rare the other type knows what to do with a xarray object, so I think we should retry using the wrapped object.~ I don't know the reason for the current implementation, though, so I could be missing something. For reference, this only is a problem with functions that accept multiple values, like numpy.maximum. Any thoughts on this, @shoyer?

Edit: actually, that smells like a type hierarchy issue, as discussed in hgrecco/pint#845 and dask/dask#5329

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   539988974