home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 608102002

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3924#issuecomment-608102002 https://api.github.com/repos/pydata/xarray/issues/3924 608102002 MDEyOklzc3VlQ29tbWVudDYwODEwMjAwMg== 5635139 2020-04-02T21:33:29Z 2020-04-02T21:33:29Z MEMBER

Hi @zxdawn thanks for the PR, appreciate you making a first contribution.

I don't know this code that well, but your examples look reasonable. Any thoughts from those that know this better, @spencerkclark @huard @dcherian ?

If we do go ahead and merge this solution, we'd need tests @zxdawn , would you be up for writing those?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  591643901
Powered by Datasette · Queries took 237.494ms · About: xarray-datasette