home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 606114972

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3919#issuecomment-606114972 https://api.github.com/repos/pydata/xarray/issues/3919 606114972 MDEyOklzc3VlQ29tbWVudDYwNjExNDk3Mg== 14808389 2020-03-30T16:49:40Z 2020-03-30T16:51:34Z MEMBER

the non-serializable lock from the failing rasterio test is from https://github.com/pydata/xarray/blob/280a14ff5298c83fcee23e1e18e3a37397856ea9/xarray/backends/locks.py#L6-L10 which means the assumption that if we don't use dask we don't need to worry about serialization is incorrect (or the rasterio code uses the serializable lock in unintended ways)?

Also, the chunks parameter of open_zarr defaults to "auto", meaning it tries to chunk by default, even if dask is not available. Should we check the availability of dask and overwrite chunks="auto" with chunks=None if we can't import dask? This would reduce the number of failing zarr tests from 98 to 2. Edit: see fa37ee6

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  589886157
Powered by Datasette · Queries took 0.726ms · About: xarray-datasette