issue_comments: 606100412

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3910#issuecomment-606100412 https://api.github.com/repos/pydata/xarray/issues/3910 606100412 MDEyOklzc3VlQ29tbWVudDYwNjEwMDQxMg== 31126826 2020-03-30T16:22:04Z 2020-03-30T16:22:04Z CONTRIBUTOR

Yes. But the not-in-place addition A+B works fine without conversion to float because it uses basically xr.align(A, B, join='inner'). If the in-place addition did the same, there would be no risk of type conversion. But I guess the in-place version would rather use something like xr.align(A, B, join='left') to guarantee that the shape and index of A does not change. Am I right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   589632313