issue_comments: 605640846

I think this is actually a python issue: python def _make_cf(self): self = xr.decode_cf(self) since self is a variable name in python (by convention referring to the instance, but it is not treated different from other names), this 1. calculates xr.decode_cf(self) which returns a new dataset with decoded values 2. reassigns self to the result (so it does not refer to the class instance anymore)

So that while this was intended to be a inplace modification, it actually is the same as python def _make_cf(self): xr.decode_cf(self) and does not do anything to the object.

In cases like this, use either aggregation or the register_dataset_accessor. Here's how this looks with aggregation: ```python class XResult: def init(self, data=None, coords=None, attrs=None, kwargs): if isinstance(data, str): kwargs = dict(READ_KWARGS, kwargs) with xr.open_dataset(data, **kwargs) as data: attrs = data.attrs

    self._data = xr.Dataset(data, coords, attrs)
    self._make_cf(self._data)

def _make_cf(self):
    self._data = xr.decode_cf(self._data)

```