issue_comments: 604659118

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3891#issuecomment-604659118 https://api.github.com/repos/pydata/xarray/issues/3891 604659118 MDEyOklzc3VlQ29tbWVudDYwNDY1OTExOA== 1217238 2020-03-26T20:09:59Z 2020-03-26T20:09:59Z MEMBER

See https://github.com/pydata/xarray/issues/1614 for related discussion.

I'm happy to set aside backwards compatibility concerns for now and ponder what the ideal policy would be. The original choices here were not made in a super careful way.

My longest-standing concern here is about units. One common use case for attrs is to mark the units of an array, and those aren't always preserved by naive arithmetic. But perhaps this is less of a concern now that you can use pint with xarray?

The other concern is how to combine attrs in operations that involve multiple arrays. Currently we just copy attrs from the first object, but that probably is not the most consistent (e.g., ideally arithmetic should be reflexive).

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   587895591