issue_comments: 603900793
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3871#issuecomment-603900793 | https://api.github.com/repos/pydata/xarray/issues/3871 | 603900793 | MDEyOklzc3VlQ29tbWVudDYwMzkwMDc5Mw== | 2272878 | 2020-03-25T15:19:01Z | 2020-03-25T15:19:01Z | CONTRIBUTOR | That could work. The corner case we would need to decide on is again promotion. What happens if the fill value is a "higher" type in the numeric tower than the original type? What if it is lower?
What if someone tries to use a string type for numeric data or vice versus? If we do option 1 that is easy. Otherwise we probably need to use numpy casting rules? What about an object dtype fill value? What about a date/time regard dtype? On Mon, Mar 23, 2020, 23:49 Stephan Hoyer notifications@github.com wrote:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
584837010 |