issue_comments: 602287483

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3871#issuecomment-602287483 https://api.github.com/repos/pydata/xarray/issues/3871 602287483 MDEyOklzc3VlQ29tbWVudDYwMjI4NzQ4Mw== 1217238 2020-03-22T22:37:40Z 2020-03-22T22:37:40Z MEMBER

In general this is really nicely put together. My main asks:

  1. Remove the unrelated API change to map
  2. Think about if the alternative of returning an arbitrary value rather than promotion or raising an error.

For details see the comments above. If we want to support (2), then it might make sense to use a string for selecting values of promote rather than True/False/None (e.g., so we can include the option to return an arbitrary coordinate value).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   584837010