issue_comments: 602225731

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3643#issuecomment-602225731 https://api.github.com/repos/pydata/xarray/issues/3643 602225731 MDEyOklzc3VlQ29tbWVudDYwMjIyNTczMQ== 14808389 2020-03-22T15:26:32Z 2020-03-22T16:59:07Z MEMBER

I think this is almost ready. For remaining issues see https://github.com/pydata/xarray/pull/3643#issue-354872657: we have a few issues with non-numpy libraries (scipy, bottleneck, numbagg) and the semi-public numpy.lib.stride_tricks.as_strided and of course the indexing does not work either.

Also, I tried to add tests for using numpy functions on DataArray objects, but some of these seem to depend on DataArray.__array_function__ which is not defined (e.g. np.median, np.searchsorted, np.clip). The result is then the same as the result of func(np.asarray(da)) so units obviously get stripped. Should we make this work?

I marked all of these tests as xfail for now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   539988974