issue_comments: 598558696

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3858#issuecomment-598558696 https://api.github.com/repos/pydata/xarray/issues/3858 598558696 MDEyOklzc3VlQ29tbWVudDU5ODU1ODY5Ng== 1217238 2020-03-13T05:38:46Z 2020-03-13T05:38:46Z MEMBER

Thanks for putting together this pull request!

My main concern here is that setting environment variables feels pretty decoupled from the logic of open_dataset. It's also rather poor design to make a library only programmable from environment variables, so I wouldn't want to encourage other backends to make use of this practice.

What do you think about writing your own utility for this sort of thing? e.g., based on one of these examples from StackOverflow: https://stackoverflow.com/questions/2059482/python-temporarily-modify-the-current-processs-environment

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   579722569