issue_comments: 592964963

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3801#issuecomment-592964963 https://api.github.com/repos/pydata/xarray/issues/3801 592964963 MDEyOklzc3VlQ29tbWVudDU5Mjk2NDk2Mw== 29958771 2020-02-29T16:49:25Z 2020-02-29T16:49:25Z CONTRIBUTOR

Re the 2nd 'failure mode': IIUC the current tests should still pass, and that's a separate (and correct) case; is that right?

That's right. The original test used test_reduce_keep_attrs as a template. Now, instead of defining one Variable object and passing it to both test conditions, a new Variable is defined and coarsened to check each setting of the global option.

I will merge master in and add similar tests for Rolling.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   571743567