issue_comments: 592219280

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3801#issuecomment-592219280 https://api.github.com/repos/pydata/xarray/issues/3801 592219280 MDEyOklzc3VlQ29tbWVudDU5MjIxOTI4MA== 5635139 2020-02-27T22:54:06Z 2020-02-27T22:54:06Z MEMBER

@amcnicho

  • Your current Rolling implementation looks good. Does that work?
  • For Coarsen, adding keep_attrs to the constructor is right, and then it needs to be assigned it to the object
  • Unlike the Rolling implementation, you can add the logic for keeping attrs within the wrapped_func (i.e. here ), by branching on the value of self.keep_attrs; self there is the Coarsen object.

Does that make sense?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   571743567