home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 589862431

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3706#issuecomment-589862431 https://api.github.com/repos/pydata/xarray/issues/3706 589862431 MDEyOklzc3VlQ29tbWVudDU4OTg2MjQzMQ== 1217238 2020-02-21T22:23:31Z 2020-02-21T22:23:31Z MEMBER

Also, concerning the commutative operations: should we wait for hgrecco/pint#1019 and remove the flipped parameters or should we merge as is and possibly revert once pint implements a type casting hierarchy?

I don't anticipate any performance cost to this, just a small decrease in readability. So I think this is fine to merge for now with comments in the relevant sections and we can revert it later. My only suggestion is to add a note like TODO: revert after https://github.com/hgrecco/pint/issues/1019 is fixed to each comment.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  551680561
Powered by Datasette · Queries took 0.735ms · About: xarray-datasette