home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 588356641

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3706#issuecomment-588356641 https://api.github.com/repos/pydata/xarray/issues/3706 588356641 MDEyOklzc3VlQ29tbWVudDU4ODM1NjY0MQ== 14808389 2020-02-19T17:56:09Z 2020-02-19T17:56:09Z MEMBER

If strict unit checking is required, I think that may be better served by an additional assert unit == "meter" type statement.

which is what I've been doing with assert_units_equal. I'll change the tests for identical, then.

Also, concerning the commutative operations: should we wait for hgrecco/pint#1019 and remove the flipped parameters or should we merge as is and possibly revert once pint implements a type casting hierarchy?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  551680561
Powered by Datasette · Queries took 80.366ms · About: xarray-datasette