issue_comments: 585612496

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3596#issuecomment-585612496 https://api.github.com/repos/pydata/xarray/issues/3596 585612496 MDEyOklzc3VlQ29tbWVudDU4NTYxMjQ5Ng== 12862013 2020-02-13T08:37:16Z 2020-02-13T08:37:16Z CONTRIBUTOR

Hi @dcherian

Once again an excellent code review :-)

I adressed most points in your review, except for the function signature of DataArray.pad. I think I prefer the default values of None. Now numpy/Dask will throw an error when you set invalid combinations e.g. constant_values=0, and set the mode="mean". The np.nan is unfortunate, but this is the difference between np.nan and xarray.dtypes.NaN. I could set the default to dtypes.NaN, but then you lose the automatic error when setting an explicit value with mode!="constant".

I can also see that something like coords_mode being useful, but I think it would be wise to wait and see how pad gets used and what issues we run into along the way.

I also ran into a small issue with pint (https://github.com/hgrecco/pint/issues/1026), but I'll get to that once this PR is merged.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   532940062