issue_comments: 584975960
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/3315#issuecomment-584975960 | https://api.github.com/repos/pydata/xarray/issues/3315 | 584975960 | MDEyOklzc3VlQ29tbWVudDU4NDk3NTk2MA== | 10554254 | 2020-02-12T01:46:00Z | 2020-02-12T01:46:00Z | NONE | Few observations after looking at the default flags for
The description of Another option is ```python objs = [xr.DataArray([0], dims='x', name='a'), xr.DataArray([1], dims='x', name='b')] xr.concat(objs, dim='x', compat='identical') ```
... and is the case for ``` objs = [xr.Dataset({'a': ('x', [0])}), xr.Dataset({'b': ('x', [0])})] xr.concat(objs, dim='x') ```
However, ```python objs = [xr.DataArray([0], dims='x', name='a', attrs={'foo':1}), xr.DataArray([1], dims='x', name='a', attrs={'bar':2})] xr.concat(objs, dim='x', compat='identical') ``` succeeds with
but again fails on Datasets, as one would expect from the description. ```python ds1 = xr.Dataset({'a': ('x', [0])}) ds1.attrs['foo'] = 'example attribute' ds2 = xr.Dataset({'a': ('x', [1])}) ds2.attrs['bar'] = 'example attribute' objs = [ds1,ds2] xr.concat(objs, dim='x',compat='identical') ```
Also had a look at Potential resolutions:
Final thought: perhaps promoting to Dataset when all requirements are met for a DataArray to be considered as such, might simplify keeping operations and checks consistent? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
494906646 |