issue_comments: 583562118

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3706#issuecomment-583562118 https://api.github.com/repos/pydata/xarray/issues/3706 583562118 MDEyOklzc3VlQ29tbWVudDU4MzU2MjExOA== 3460034 2020-02-07T19:17:08Z 2020-02-07T19:17:08Z CONTRIBUTOR

@keewis For what it is worth, as far as identical goes, I think it makes the most sense to treat unit matching like dtype matching as @shoyer mentioned. Although, I had interpreted @max-sixty's comment https://github.com/pydata/xarray/pull/3238#issuecomment-533181017 to mean that dtypes are compared, it appears from @shoyer's comment https://github.com/pydata/xarray/pull/3706#issuecomment-583259053 that this not the case. If strict unit checking is required, I think that may be better served by an additional assert unit == "meter" type statement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   551680561