issue_comments: 583349241

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3706#issuecomment-583349241 https://api.github.com/repos/pydata/xarray/issues/3706 583349241 MDEyOklzc3VlQ29tbWVudDU4MzM0OTI0MQ== 14808389 2020-02-07T11:21:55Z 2020-02-07T11:21:55Z MEMBER

when writing the unit tests, we decided the definition of equals to be different from identical (see https://github.com/pydata/xarray/pull/3238#issuecomment-533145925 and https://github.com/pydata/xarray/pull/3238#issuecomment-533181017) which would be consistent with the behaviour of identical when a "units" attribute is set.

As far as I know there was no real use case (except from being able to use assert_identical in the unit tests), so we can change that.

cc @jthielen

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   551680561