issue_comments: 582538190

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3601#issuecomment-582538190 https://api.github.com/repos/pydata/xarray/issues/3601 582538190 MDEyOklzc3VlQ29tbWVudDU4MjUzODE5MA== 3958036 2020-02-05T18:09:24Z 2020-02-05T18:09:24Z CONTRIBUTOR

I've added an extra test that checks the right thing happens when we do not change the bad, under or over colors. That test needs to set vmin and vmax to get sensible defaults for the under and over colors: without vmin or vmax, mpl.colors.from_levels_and_colors() is called with extend = 'neither'; then it sets _rgba_under and _rgba_over in its result to (0.0, 0.0, 0.0, 0.0) (but these values can never be used, because with no vmin or vmax there can be no data outside of the plotted range).

I think this is ready now. The unit test failures on my local computer appear to be unrelated to this PR (see earlier references to #3673 by @keewis and #3747 by @mathause).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   533996523