issue_comments: 568938317

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3643#issuecomment-568938317 https://api.github.com/repos/pydata/xarray/issues/3643 568938317 MDEyOklzc3VlQ29tbWVudDU2ODkzODMxNw== 14808389 2019-12-25T23:40:59Z 2019-12-26T18:23:17Z MEMBER

~The aggregation tests fail because numpy.median needs __array_function__ to be implemented, but I think that's out of scope for this PR.~ I marked it as xfailing.

The bivariate ufunc test is fixed by hgrecco/pint#951.

shift could be fixed by using python filler = np.full_like(np.resize(trimmed_data, shape), fill_value, dtype=dtype) instead of https://github.com/pydata/xarray/blob/651f27fd5176674da315501026dc18a03b575a76/xarray/core/variable.py#L1105-L1112 but I didn't check if that would be a bad for performance (and pint would have to implement np.resize). However, that would not work for dask arrays so I'm not sure what to do.

rolling uses bottleneck which does not play nice with pint, yet. I'd suggest using python if bottleneck_move_func is not None and not isinstance( self.obj.data, dask_array_type ) and not hasattr(self.obj.data, "__array_function__"): instead of https://github.com/pydata/xarray/blob/651f27fd5176674da315501026dc18a03b575a76/xarray/core/rolling.py#L363-L365 If we go with that, we'd need pint to implement np.pad.

Edit: I added it, but this still requires np.pad. However, it makes a lot of other, unrelated tests fail, so I removed the commit again.

Unless I missed something, these should be the only issues left for pint support in DataArray (not counting the IndexVariable issue).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   539988974