issue_comments: 568106485

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3649#issuecomment-568106485 https://api.github.com/repos/pydata/xarray/issues/3649 568106485 MDEyOklzc3VlQ29tbWVudDU2ODEwNjQ4NQ== 2448579 2019-12-20T22:11:02Z 2019-12-20T22:11:02Z MEMBER

Imagine if someone passes a bunch of datasets that they think form a hypercube but don't, then with the PR they would get returned a dataset with a panel of NaNs that they would not be explicitly told are there... On the other hand xarray's other combining functions (e.g. merge and concat) will just insert NaNs.

Yeah this "automatic alignment" behaviour is everywhere so I think it makes sense for it to be the default.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   540601428